On 2019/7/23 0:14, Lorenzo Pieralisi wrote: > Commit 36a2ba07757d ("ACPI/IORT: Reject platform device creation on NUMA > node mapping failure") introduced a local variable 'node' in > arm_smmu_v3_set_proximity() that shadows the struct acpi_iort_node > pointer function parameter. > > Execution was unaffected but it is prone to errors and can lead > to subtle bugs. > > Rename the local variable to prevent any issue. > > Reported-by: Will Deacon <will@xxxxxxxxxx> > Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@xxxxxxx> > Cc: Will Deacon <will@xxxxxxxxxx> > Cc: Hanjun Guo <guohanjun@xxxxxxxxxx> > Cc: Sudeep Holla <sudeep.holla@xxxxxxx> > Cc: Catalin Marinas <catalin.marinas@xxxxxxx> > Cc: Robin Murphy <robin.murphy@xxxxxxx> > Cc: Kefeng Wang <wangkefeng.wang@xxxxxxxxxx> > --- > drivers/acpi/arm64/iort.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Hanjun Guo <guohanjun@xxxxxxxxxx>