Hi Tyler, >-----Original Message----- >From: linux-acpi-owner@xxxxxxxxxxxxxxx [mailto:linux-acpi- >owner@xxxxxxxxxxxxxxx] On Behalf Of Tyler Baicar OS >Sent: 02 July 2019 17:52 >To: Open Source Submission <patches@xxxxxxxxxxxxxxxxxxx>; linux-arm- >kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux- >acpi@xxxxxxxxxxxxxxx; linux-edac@xxxxxxxxxxxxxxx; james.morse@xxxxxxx; >catalin.marinas@xxxxxxx; will@xxxxxxxxxx; lorenzo.pieralisi@xxxxxxx; >Guohanjun (Hanjun Guo) <guohanjun@xxxxxxxxxx>; sudeep.holla@xxxxxxx; >rjw@xxxxxxxxxxxxx; lenb@xxxxxxxxxx; mark.rutland@xxxxxxx; >tony.luck@xxxxxxxxx; bp@xxxxxxxxx; Matteo.Carlini@xxxxxxx; >Andrew.Murray@xxxxxxx >Cc: Tyler Baicar OS <baicar@xxxxxxxxxxxxxxxxxxxxxx> >Subject: [PATCH RFC 1/4] ACPI/AEST: Initial AEST driver > >Add support for parsing the ARM Error Source Table and basic handling of >errors reported through both memory mapped and system register interfaces. > >Signed-off-by: Tyler Baicar <baicar@xxxxxxxxxxxxxxxxxxxxxx> >--- > arch/arm64/include/asm/ras.h | 41 +++++ > arch/arm64/kernel/Makefile | 2 +- > arch/arm64/kernel/ras.c | 67 ++++++++ > drivers/acpi/arm64/Kconfig | 3 + > drivers/acpi/arm64/Makefile | 1 + > drivers/acpi/arm64/aest.c | 362 >+++++++++++++++++++++++++++++++++++++++++++ > include/linux/acpi_aest.h | 94 +++++++++++ > 7 files changed, 569 insertions(+), 1 deletion(-) create mode 100644 >arch/arm64/include/asm/ras.h create mode 100644 arch/arm64/kernel/ras.c >create mode 100644 drivers/acpi/arm64/aest.c create mode 100644 >include/linux/acpi_aest.h > >diff --git a/arch/arm64/include/asm/ras.h b/arch/arm64/include/asm/ras.h >new file mode 100644 index 0000000..36bfff4 >--- /dev/null >+++ b/arch/arm64/include/asm/ras.h >@@ -0,0 +1,41 @@ >+/* SPDX-License-Identifier: GPL-2.0 */ >+#ifndef __ASM_RAS_H >+#define __ASM_RAS_H >+ >+#define ERR_STATUS_AV BIT(31) >+#define ERR_STATUS_V BIT(30) >+#define ERR_STATUS_UE BIT(29) >+#define ERR_STATUS_ER BIT(28) >+#define ERR_STATUS_OF BIT(27) >+#define ERR_STATUS_MV BIT(26) >+#define ERR_STATUS_CE_SHIFT 24 >+#define ERR_STATUS_CE_MASK 0x3 >+#define ERR_STATUS_DE BIT(23) >+#define ERR_STATUS_PN BIT(22) >+#define ERR_STATUS_UET_SHIFT 20 >+#define ERR_STATUS_UET_MASK 0x3 >+#define ERR_STATUS_IERR_SHIFT 8 >+#define ERR_STATUS_IERR_MASK 0xff >+#define ERR_STATUS_SERR_SHIFT 0 >+#define ERR_STATUS_SERR_MASK 0xff >+ >+#define ERR_FR_CEC_SHIFT 12 >+#define ERR_FR_CEC_MASK 0x7 >+ >+#define ERR_FR_8B_CEC BIT(1) >+#define ERR_FR_16B_CEC BIT(2) >+ >+struct ras_ext_regs { >+ u64 err_fr; >+ u64 err_ctlr; >+ u64 err_status; >+ u64 err_addr; >+ u64 err_misc0; >+ u64 err_misc1; >+ u64 err_misc2; >+ u64 err_misc3; err_misc2 and err_misc3 are not used. Are they for the future purpose? >+}; >+ >+void arch_arm_ras_report_error(void); >+ >+#endif /* __ASM_RAS_H */ [...] >+ >+int __init acpi_aest_init(void) >+{ >+ struct acpi_table_aest *aest; >+ struct aest_type_header *aest_node, *aest_end; >+ int i, ret = 0; >+ >+ if (acpi_disabled) >+ return 0; >+ >+ if (ACPI_FAILURE(acpi_get_table(ACPI_SIG_AEST, 0, &aest_table))) >+ return -EINVAL; >+ >+ aest = (struct acpi_table_aest *)aest_table; >+ >+ /* Get the first AEST node */ >+ aest_node = ACPI_ADD_PTR(struct aest_type_header, aest, >+ sizeof(struct acpi_table_aest)); >+ /* Pointer to the end of the AEST table */ >+ aest_end = ACPI_ADD_PTR(struct aest_type_header, aest, >+ aest_table->length); >+ >+ while (aest_node < aest_end) { >+ if (((u64)aest_node + aest_node->length) > (u64)aest_end) { >+ pr_err("AEST node pointer overflow, bad table\n"); >+ return -EINVAL; >+ } >+ >+ aest_count_ppi(aest_node); >+ >+ aest_node = ACPI_ADD_PTR(struct aest_type_header, >aest_node, >+ aest_node->length); >+ } >+ >+ if (num_ppi > AEST_MAX_PPI) { >+ pr_err("Limiting PPI support to %d PPIs\n", AEST_MAX_PPI); >+ num_ppi = AEST_MAX_PPI; >+ } >+ >+ ppi_data = kcalloc(num_ppi, sizeof(struct aest_node_data *), >+ GFP_KERNEL); >+ >+ for (i = 0; i < num_ppi; i++) { >+ ppi_data[i] = alloc_percpu(struct aest_node_data); >+ if (!ppi_data[i]) { >+ ret = -ENOMEM; >+ break; >+ } >+ } >+ >+ if (ret) { >+ pr_err("Failed percpu allocation\n"); >+ for (i = 0; i < num_ppi; i++) >+ free_percpu(ppi_data[i]); I think 'ppi_data' to be freed here? >+ return ret; [...] >+ >+#endif /* AEST_H */ >-- >1.8.3.1 Thanks, Shiju
