On Thu, Jun 20, 2019 at 02:34:16PM +0100, Charles Keepax wrote:
> In preparation for future refactoring factor out the fetch of the IRQ
> into its own helper function.
> +static int i2c_acpi_get_irq(struct acpi_device *adev)
> +{
> + struct list_head resource_list;
> + int irq = -ENOENT;
> + int ret;
> +
> + INIT_LIST_HEAD(&resource_list);
> +
> + ret = acpi_dev_get_resources(adev, &resource_list,
> + i2c_acpi_add_resource, &irq);
> + if (ret < 0)
> + return -EINVAL;
Can't we return ret value?
> +
> + acpi_dev_free_resource_list(&resource_list);
> +
> + return irq;
> +}
> + ret = i2c_acpi_get_irq(adev);
> + if (ret > 0)
> + info->irq = ret;
And on error we do not bail out. This changes the behaviour.
--
With Best Regards,
Andy Shevchenko
