On Tue, Jun 18, 2019 at 10:38 AM Suzuki K Poulose <suzuki.poulose@xxxxxxx> wrote: > > Hi Rafael, > > On 17/06/2019 23:07, Rafael J. Wysocki wrote: > > On Fri, Jun 14, 2019 at 7:55 PM Suzuki K Poulose <suzuki.poulose@xxxxxxx> wrote: > >> > >> Add a generic helper to match a device by the ACPI_COMPANION device. > >> This will be later used for providing wrappers for > >> (bus/class/driver)_find_device(). > >> > >> Cc: Len Brown <lenb@xxxxxxxxxx> > >> Cc: linux-acpi@xxxxxxxxxxxxxxx > >> Cc: linux-spi@xxxxxxxxxxxxxxx > >> Cc: Mark Brown <broonie@xxxxxxxxxx> > >> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > >> Cc: "Rafael J. Wysocki" <rafael@xxxxxxxxxx> > >> Signed-off-by: Suzuki K Poulose <suzuki.poulose@xxxxxxx> > > > > Please fold this change into the patch adding users of device_match_acpi_dev(). > > There are variants of this by class/bus/driver and all of them are introduced > as separate patches with the respective users. If we do for this, we have to > do the same for other matches as well. > > i.e, [ device_match_by_attr + class_find_device_by_attr & users + > driver_find_device_by_attr & users + bus_find_device_by_attr & users ] > > And that becomes a large chunk, which could make the review painful. > > If you would still like that approach, I could do that in the next revision. Yes, please.
