Re: [RFC PATCH] gpio/acpi: set direction for ACPI OpRegion GPIOs

[Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx>]

On Wed, 29 May 2019 at 12:27, Mika Westerberg
<mika.westerberg@xxxxxxxxxxxxxxx> wrote:
>
> On Wed, May 29, 2019 at 12:13:42PM +0200, Ard Biesheuvel wrote:
> > The ACPI GPIO OpRegion code never sets the direction for GPIOs that
> > it configures from scratch, leaving unconfigured GPIOs to be left
> > at the default direction, which is typically input not output.
>
> The code does:
>
>   enum gpiod_flags flags = acpi_gpio_to_gpiod_flags(agpio);
>
> before it requests the GPIO. Isn't that sufficient?

Yes, it works if I set the PullXxx value explicitly in the GpioIo() resource.