On Mon, May 27, 2019 at 01:27:17PM +0200, Ard Biesheuvel wrote: > + > +/** > + * acpi_irq_create_hierarchy - Create a hierarchical IRQ domain with the default > + * GSI domain as its parent. Please document the arguments as well. > + */ > +struct irq_domain *acpi_irq_create_hierarchy(unsigned int flags, > + unsigned int size, > + struct fwnode_handle *fwnode, > + const struct irq_domain_ops *ops, > + void *host_data) Otherwise looks good to me. Reviewed-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>