Re: [alsa-devel] [PATCH v2] ACPI / device_sysfs: change _ADR representation to 64 bits

Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx> · Tue, 14 May 2019 16:37:13 -0500

diff --git a/drivers/acpi/device_sysfs.c b/drivers/acpi/device_sysfs.c
index 8940054d6250..7dda0ee05cd1 100644
--- a/drivers/acpi/device_sysfs.c
+++ b/drivers/acpi/device_sysfs.c
@@ -428,8 +428,10 @@ static ssize_t acpi_device_adr_show(struct device *dev,
  {
       struct acpi_device *acpi_dev = to_acpi_device(dev);

-     return sprintf(buf, "0x%08x\n",
-                    (unsigned int)(acpi_dev->pnp.bus_address));
+     if (acpi_dev->pnp.bus_address > 0xFFFFFFFF)

Would prefer to use U32_MAX instead of 0xFFFFFFFF

I would.


I have made that change manually and applied the patch.

Thanks!

Thanks, much appreciated.






