On Fri, Apr 12, 2019 at 5:20 PM Yue Haibing <yuehaibing@xxxxxxxxxx> wrote: > From: YueHaibing <yuehaibing@xxxxxxxxxx> > > When building CONFIG_ACPI is not set > gcc warn this: > > drivers/gpio/gpio-merrifield.c: In function mrfld_gpio_get_pinctrl_dev_name: > drivers/gpio/gpio-merrifield.c:388:19: error: dereferencing pointer to incomplete type struct acpi_device > put_device(&adev->dev); > ^~ > > Reported-by: Hulk Robot <hulkci@xxxxxxxxxx> > Fixes:d00d2109c367 ("gpio: merrifield: Convert to use acpi_dev_get_first_match_dev()") > Suggested-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx> This doesn't apply cleanly to any GPIO branch (devel or fixes) so I assume it is supposed to be applied to the ACPI tree. Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx> Yours, Linus Walleij