Re: [PATCH v3 00/10] ACPI / utils: Replace leaky function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 28-03-19 18:17, Andy Shevchenko wrote:
The acpi_dev_get_first_match_name() is missing put_device() call
and thus keeping reference counting unbalanced.

In order to fix the issue introduce a new helper to convert existing users
one-by-one to a better API.

Since v3:
- convert all existing users and drop old API (Mika)
- add Hans' tag

Cc: MyungJoo Ham <myungjoo.ham@xxxxxxxxxxx>
Cc: Chanwoo Choi <cw00.choi@xxxxxxxxxxx>
Cc: Chen-Yu Tsai <wens@xxxxxxxx>
Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
Cc: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>

Andy Shevchenko (10):
   ACPI / utils: Introduce acpi_dev_get_first_match_dev() helper
   extcon: axp288: Convert to use acpi_dev_get_first_match_dev()
   gpio: merrifield: Convert to use acpi_dev_get_first_match_dev()
   ASoC: Intel: bytcht_da7213: Convert to use
     acpi_dev_get_first_match_dev()
   ASoC: Intel: bytcht_es8316: Convert to use
     acpi_dev_get_first_match_dev()
   ASoC: Intel: bytcr_rt5640: Convert to use
     acpi_dev_get_first_match_dev()
   ASoC: Intel: bytcr_rt5651: Convert to use
     acpi_dev_get_first_match_dev()
   ASoC: Intel: cht_bsw_rt5645: Convert to use
     acpi_dev_get_first_match_dev()
   ASoC: Intel: cht_bsw_rt5672: Convert to use
     acpi_dev_get_first_match_dev()
   ACPI / utils: Remove deprecated function since no user left

The entire series looks good to me:

Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx>

For the entire series.

Regards,

Hans




  drivers/acpi/utils.c                    | 16 ++++++++++------
  drivers/extcon/extcon-axp288.c          |  9 +++++----
  drivers/gpio/gpio-merrifield.c          | 18 ++++++++++++++----
  include/acpi/acpi_bus.h                 |  4 ++--
  include/linux/acpi.h                    |  4 ++--
  sound/soc/intel/boards/bytcht_da7213.c  |  9 +++++----
  sound/soc/intel/boards/bytcht_es8316.c  |  9 +++++----
  sound/soc/intel/boards/bytcr_rt5640.c   | 10 +++++-----
  sound/soc/intel/boards/bytcr_rt5651.c   | 14 ++++++++------
  sound/soc/intel/boards/cht_bsw_rt5645.c |  9 +++++----
  sound/soc/intel/boards/cht_bsw_rt5672.c |  9 +++++----
  11 files changed, 66 insertions(+), 45 deletions(-)




[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux