On 3/12/19 10:47 PM, Schmauss, Erik wrote:
Go ahead and revert this commit and try the following:
This worked in 5.0. In 5.1-rc1 ACPI_LV_DEBUG_OBJECT is set as a default,
even with this fix.
Alex
diff --git a/include/acpi/platform/aclinux.h b/include/acpi/platform/aclinux.h
index e3d21d014fcc..6310e1b02385 100644
--- a/include/acpi/platform/aclinux.h
+++ b/include/acpi/platform/aclinux.h
@@ -82,6 +82,8 @@
#define ACPI_NO_ERROR_MESSAGES
#undef ACPI_DEBUG_OUTPUT
+#undef ACPI_DEBUG_DEFAULT
+#define ACPI_DEBUG_DEFAULT (ACPI_LV_INFO | ACPI_LV_REPAIR)
/* External interface for __KERNEL__, stub is needed */
#define ACPI_EXTERNAL_RETURN_STATUS(prototype) \
I think this acpi_early_init is called after the commandline parameters are
set.
I wonder if there's a way to give the cmdline parameter a default
value. That would solve this issue and not unsolve the previous.
Sorry about the breakage! I thought I had tested this fairly thoroughly... The
main issue is that ACPICA and Linux use different defaults and this was
intended to be a simple way to reduce the divergence between the
codebases. I'll take a look at this.
Thanks,
Erik
Alex
Erik
Alex
Appendix A: kernel commandline and resulting acpi parameters
$ cat /proc/cmdline
BOOT_IMAGE=/vmlinuz-5.0.0+ root=/dev/mapper/fedora-root ro
rd.lvm.lv=fedora/root rd.lvm.lv=fedora/home console=tty0
console=ttyS1,115200n8 rhgb acpi.debug_layer=0xffffffff
acpi.debug_level=0x2 LANG=en_US.UTF-8
$ cat /sys/module/acpi/parameters/debug_l*
Description Hex SET
ACPI_UTILITIES 0x00000001 [*]
ACPI_HARDWARE 0x00000002 [*]
ACPI_EVENTS 0x00000004 [*]
ACPI_TABLES 0x00000008 [*]
ACPI_NAMESPACE 0x00000010 [*]
ACPI_PARSER 0x00000020 [*]
ACPI_DISPATCHER 0x00000040 [*]
ACPI_EXECUTER 0x00000080 [*]
ACPI_RESOURCES 0x00000100 [*]
ACPI_CA_DEBUGGER 0x00000200 [*]
ACPI_OS_SERVICES 0x00000400 [*]
ACPI_CA_DISASSEMBLER 0x00000800 [*]
ACPI_COMPILER 0x00001000 [*]
ACPI_TOOLS 0x00002000 [*]
ACPI_BUS_COMPONENT 0x00010000 [*]
ACPI_AC_COMPONENT 0x00020000 [*]
ACPI_BATTERY_COMPONENT 0x00040000 [*]
ACPI_BUTTON_COMPONENT 0x00080000 [*]
ACPI_SBS_COMPONENT 0x00100000 [*]
ACPI_FAN_COMPONENT 0x00200000 [*]
ACPI_PCI_COMPONENT 0x00400000 [*]
ACPI_POWER_COMPONENT 0x00800000 [*]
ACPI_CONTAINER_COMPONENT 0x01000000 [*]
ACPI_SYSTEM_COMPONENT 0x02000000 [*]
ACPI_THERMAL_COMPONENT 0x04000000 [*]
ACPI_MEMORY_DEVICE_COMPONENT 0x08000000 [*]
ACPI_VIDEO_COMPONENT 0x10000000 [*]
ACPI_PROCESSOR_COMPONENT 0x20000000 [*]
ACPI_ALL_DRIVERS 0xFFFF0000 [*]
--
debug_layer = 0xFFFFFFFF ( * = enabled)
Description Hex SET
ACPI_LV_INIT 0x00000001 [ ]
0x00000002 [ ]
ACPI_LV_INFO 0x00000004 [*]
ACPI_LV_REPAIR 0x00000008 [*]
ACPI_LV_TRACE_POINT 0x00000010 [ ]
ACPI_LV_INIT_NAMES 0x00000020 [ ]
ACPI_LV_PARSE 0x00000040 [ ]
ACPI_LV_LOAD 0x00000080 [ ]
ACPI_LV_DISPATCH 0x00000100 [ ]
ACPI_LV_EXEC 0x00000200 [ ]
ACPI_LV_NAMES 0x00000400 [ ]
ACPI_LV_OPREGION 0x00000800 [ ]
ACPI_LV_BFIELD 0x00001000 [ ]
ACPI_LV_TABLES 0x00002000 [ ]
ACPI_LV_VALUES 0x00004000 [ ]
ACPI_LV_OBJECTS 0x00008000 [ ]
ACPI_LV_RESOURCES 0x00010000 [ ]
ACPI_LV_USER_REQUESTS 0x00020000 [ ]
ACPI_LV_PACKAGE 0x00040000 [ ]
ACPI_LV_ALLOCATIONS 0x00100000 [ ]
ACPI_LV_FUNCTIONS 0x00200000 [ ]
ACPI_LV_OPTIMIZATIONS 0x00400000 [ ]
ACPI_LV_MUTEX 0x01000000 [ ]
ACPI_LV_THREADS 0x02000000 [ ]
ACPI_LV_IO 0x04000000 [ ]
ACPI_LV_INTERRUPTS 0x08000000 [ ]
ACPI_LV_AML_DISASSEMBLE 0x10000000 [ ]
ACPI_LV_VERBOSE_INFO 0x20000000 [ ]
ACPI_LV_FULL_TABLES 0x40000000 [ ]
ACPI_LV_EVENTS 0x80000000 [ ]
--
debug_level = 0x0000000C (* = enabled)
