[PATCH] ACPICA: don't leak kernel addresses

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Since commit ad67b74d2469d9b8 ("printk: hash addresses printed with %p"),
an error message prints "____ptrval____" instead of a region address:

    ACPI Error: No handler for Region [SYSI] ((____ptrval____)) [IPMI] (20180531/evregion-132)

Instead of changing the print to "%px", and leaking kernel addresses,
just remove the prints completely, like in commit 071929dbdd865f77
("arm64: Stop printing the virtual memory layout"), or just print the
region name.

Fixes: ad67b74d2469d9b8 ("printk: hash addresses printed with %p")
Signed-off-by: Matteo Croce <mcroce@xxxxxxxxxx>
---
 drivers/acpi/acpica/evregion.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/drivers/acpi/acpica/evregion.c b/drivers/acpi/acpica/evregion.c
index 45dc797df05d..e6f7b62d1d2e 100644
--- a/drivers/acpi/acpica/evregion.c
+++ b/drivers/acpi/acpica/evregion.c
@@ -125,9 +125,8 @@ acpi_ev_address_space_dispatch(union acpi_operand_object *region_obj,
 	handler_desc = region_obj->region.handler;
 	if (!handler_desc) {
 		ACPI_ERROR((AE_INFO,
-			    "No handler for Region [%4.4s] (%p) [%s]",
+			    "No handler for Region [%4.4s] [%s]",
 			    acpi_ut_get_node_name(region_obj->region.node),
-			    region_obj,
 			    acpi_ut_get_region_name(region_obj->region.
 						    space_id)));
 
@@ -150,8 +149,7 @@ acpi_ev_address_space_dispatch(union acpi_operand_object *region_obj,
 			/* No initialization routine, exit with error */
 
 			ACPI_ERROR((AE_INFO,
-				    "No init routine for region(%p) [%s]",
-				    region_obj,
+				    "No init routine for region [%s]",
 				    acpi_ut_get_region_name(region_obj->region.
 							    space_id)));
 			return_ACPI_STATUS(AE_NOT_EXIST);
@@ -439,8 +437,8 @@ acpi_ev_detach_region(union acpi_operand_object *region_obj,
 
 		if (obj_desc == start_desc) {
 			ACPI_ERROR((AE_INFO,
-				    "Circular handler list in region object %p",
-				    region_obj));
+				    "Circular handler list in region [%s]",
+				    acpi_ut_get_region_name(region_obj->region.space_id)));
 			return_VOID;
 		}
 	}
-- 
2.20.1




[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux