Re: [PATCH v2 1/2] i2c: i2c-designware-platdrv: Cleanup setting of the adapter number

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 12, 2019 at 05:07:23PM +0200, Andy Shevchenko wrote:
> On Tue, Mar 12, 2019 at 03:55:53PM +0100, Hans de Goede wrote:
> > i2c-designware-platdrv assumes that if the pdev has an apci-companion
> > it should use a dynamic adapter-nr and otherwise it will use pdev->id
> > as adapter-nr.
> > 
> > Before this commit the setting of the adapter.nr was somewhat convoluted,
> > in the acpi_companion case it was set from dw_i2c_acpi_configure, in the
> > non acpi_companion case it was set from dw_i2c_set_fifo_size based on
> > tx_fifo_depth not being set yet indicating that dw_i2c_acpi_configure was
> > not executed.
> > 
> > This cleans this up, directly setting the adapter-nr from
> > dw_i2c_plat_probe for both cases.
> > 
> 
> As has been discussed earlier, this is good one
> 
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

The other patch, too? If so, please tag it seperately, so patchwork can
pick it up. (for bigger series, tags for the cover-letter is ok for me)

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux