On Wed, Jan 23, 2019 at 11:08 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > > Hi All, > > While working on this bug: > https://bugzilla.redhat.com/show_bug.cgi?id=1665610 > > I encountered a DSDT which contains the bits: > > Starting at line 6271: > > Device (SDHB) { > ... > Name (_DDN, "Intel(R) SDIO Controller - 80862295") > ... > Device (RTLW) { > Method (_STA, 0, NotSerialized) // _STA: Status > { > Local0 = Zero > If ((^^^^GPO1.AMMR == One)) > { > If ((^^^^GPO1.WID0 == One)) > { > Local0 = One > } > > If ((^^^^GPO1.WID1 == One)) > { > Local0 += 0x02 > } > } > > If ((Local0 == Zero)) > { > Return (Zero) > } > ElseIf ((Local0 == One)) > { > Return (0x0F) > } > ElseIf ((Local0 == 0x02)) > { > Return (Zero) > } > Else > { > Return (Zero) > } > } > } > ... > } > > There are other subdevices for if the device has a Broadcom wifi module > instead of a Realtek one, which return 0xf from _STA when > Local0 == Zero. > > And then there is this bit of AML for the Bluetooth part of the > broadcom/wifi module: > > Starting at line 9779: > > Scope (URT1) > { > Device (BTH3) > { > Method (_HID, 0, NotSerialized) // _HID: Hardware ID > { > Local0 = Zero > If ((^^^^GPO1.AMMR == One)) > { > If ((^^^^GPO1.WID0 == One)) > { > Local0 = One > } > If ((^^^^GPO1.WID1 == One)) > { > Local0 += 0x02 > } > } > > If ((Local0 == Zero)) > { > Return ("BCM2E5B") > } > ElseIf ((Local0 == One)) > { > Return ("OBDA0623") > } > ElseIf ((Local0 == 0x02)) > { > Return ("BCM2E74") > } > Else > { > Return ("BCM2E5B") > } > } > } > } > > What is happening here is that two GPIOs are connected to > (solder?) jumpers which indicate which type of wifi module > is installed. And instead of the UEFI firmware reading this > at boot and then setting an ACPI variable accordingly as is > typically done for options configurable through the setup > menu, the reading of the GPIOs is done from the AML code. > > The problem here is that we evaluate the _STA and _HID > methods while enumerating the ACPI devices, which we do in > the order they are listed in the AML code. > > The GPIO devices start at line 14974, so these are not enumerated > yet when we execute the _STA and _HID methods listed above, so > they alwys take the Local0 == Zero option, while on the device from: > https://bugzilla.redhat.com/show_bug.cgi?id=1665610 > The Local0 == One option is the right one. > > I've provided the user with a DSDT override which hardcodes the > Local0 == One results for these _STA and _HID methods and that > fixes wifi and bluetooth not working on this device. So presumably there should be a _DEP to tell us that these GPIOs will be needed to enumerate the devices in question and so it is not there or we don't use it. Which is the case?
