On Mon, Jan 07, 2019 at 09:14:05PM -0800, Dan Williams wrote: > On Mon, Jan 7, 2019 at 8:59 PM Nathan Chancellor > <natechancellor@xxxxxxxxx> wrote: > > > > On arm64 little endian allyesconfig: > > > > drivers/acpi/nfit/intel.c:149:12: warning: unused function 'intel_security_unlock' [-Wunused-function] > > static int intel_security_unlock(struct nvdimm *nvdimm, > > ^ > > drivers/acpi/nfit/intel.c:230:12: warning: unused function 'intel_security_erase' [-Wunused-function] > > static int intel_security_erase(struct nvdimm *nvdimm, > > ^ > > drivers/acpi/nfit/intel.c:279:12: warning: unused function 'intel_security_query_overwrite' [-Wunused-function] > > static int intel_security_query_overwrite(struct nvdimm *nvdimm) > > ^ > > drivers/acpi/nfit/intel.c:316:12: warning: unused function 'intel_security_overwrite' [-Wunused-function] > > static int intel_security_overwrite(struct nvdimm *nvdimm, > > ^ > > 4 warnings generated. > > > > These functions are only used in __intel_security_ops when CONFIG_X86 is > > set so only define these functions under that same condition. > > Thanks for the report, not sure how the kbuild robot missed this. I'd > prefer marking the functions __maybe_unused rather than expanding the > ifdef guards. allyesconfig defaults to big endian, which doesn't built the nfit folder (haven't looked into the dependency chain to see why). I have been working with Clang and have a local patch to avoid turning on big endian mode with it for now (avoids a few other warnings for now). I can send a v2 with that change if you would like. Thanks for the quick reply, Nathan
