On Mon, Jan 07, 2019 at 12:15:54PM +0100, Hans de Goede wrote: > Implement the exec_mipi_pmic_seq_element callback for the CHT Whiskey Cove > PMIC. > > On some CHT devices this fixes the LCD panel not lighting up when it was > not initialized by the GOP, because an external monitor was plugged in and > the GOP initialized only the external monitor. > + if (i2c_client_address > 0xff || reg_address > 0xff) { > + pr_warn("%s warning addresses too big client 0x%x reg 0x%x\n", > + __func__, i2c_client_address, reg_address); I tried to parse the message and failed. Perhaps something like "%s: addresses too big for client 0x%x, reg 0x%x\n" would be easier to understand? > + return -ERANGE; > + } -- With Best Regards, Andy Shevchenko