On Wed, Jan 2, 2019 at 10:34 AM Rafael J. Wysocki <rafael@xxxxxxxxxx> wrote: > > On Sun, Dec 30, 2018 at 8:56 PM Sinan Kaya <okaya@xxxxxxxxxx> wrote: > > > > Code does unconditional select for IOSF_MBI. IOSF_MBI driver depends on > > CONFIG_PCI set but this is not specified anywhere. > > IMO it would be better to say > > "After commit 5d32a66541c46 (PCI/ACPI: Allow ACPI to be built without > CONFIG_PCI set) dependencies on CONFIG_PCI that previously were > satisfied implicitly through dependencies on CONFIG_ACPI have to be > specified directly. For this reason, add a direct dependency on > CONFIG_PCI to the IOSF_MBI driver." > > If you did that, the reviewers would know upfront what this was about > and that might save at least one back-and-forth e-mail exchange in > each case. But, of course, the changelog doesn't even match the patch contents in this particular case. Please fix that.
