On 2018/12/18 10:30, Sinan Kaya wrote: > On 12/18/2018 3:17 AM, Hanjun Guo wrote: >> Hi Sinan, >> >> On 2018/12/15 9:02, Sinan Kaya wrote: >>> Diff from v9: >>> Collect Acked-by for 3/6 >>> Rework 6/6 to stub out IORT code instead of creating a dummy function >>> >>> Sinan Kaya (6): >>> ACPI: Allow CONFIG_PCI to be unset for reboot >>> ACPI / OSL: Stub out acpi_os_(read/write)_pci_configurations() >>> PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set >>> ACPICA: Remove PCI bits from ACPICA when CONFIG_PCI is unset >>> arm64: select ACPI PCI code only both features are enabled >>> ACPI/IORT: Stub out ACS functions when CONFIG_PCI is not set >> >> I applied this patch set on top of 4.20-rc5, and enable >> "PCI slot detective driver" for ACPI based, got compile error: >> >> drivers/acpi/pci_slot.c: In function ‘register_slot’: >> drivers/acpi/pci_slot.c:123:2: error: implicit declaration of function ‘pci_create_slot’ [-Werror=implicit-function-declaration] >> pci_slot = pci_create_slot(pci_bus, device, name, NULL); >> ^ >> drivers/acpi/pci_slot.c:123:11: warning: assignment makes pointer from integer without a cast >> pci_slot = pci_create_slot(pci_bus, device, name, NULL); >> ^ >> drivers/acpi/pci_slot.c: In function ‘acpi_pci_slot_remove’: >> drivers/acpi/pci_slot.c:161:4: error: implicit declaration of function ‘pci_destroy_slot’ [-Werror=implicit-function-declaration] >> pci_destroy_slot(slot->pci_slot); >> ^ >> cc1: some warnings being treated as errors >> make[2]: *** [drivers/acpi/pci_slot.o] Error 1 >> make[2]: *** Waiting for unfinished jobs.... >> make[1]: *** [drivers/acpi] Error 2 >> make[1]: *** Waiting for unfinished jobs.... >> make: *** [drivers] Error 2 >> make: *** Waiting for unfinished jobs.... >> >> Did I miss some other patches to fix this? > > Thanks for the report. I did compilation with defconfig only. This one is an > easy fix in Kconfig to add a dependency into PCI for this driver. Yes, it is. Thanks Hanjun
