RE: [PATCH v6 5/5] ACPICA: Remove PCI bits from ACPICA when CONFIG_PCI is unset

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> -----Original Message-----
> From: Rafael J. Wysocki [mailto:rafael@xxxxxxxxxx]
> Sent: Wednesday, December 12, 2018 1:07 PM
> To: okaya@xxxxxxxxxx; Schmauss, Erik <erik.schmauss@xxxxxxxxx>
> Cc: ACPI Devel Maling List <linux-acpi@xxxxxxxxxxxxxxx>; Moore, Robert
> <robert.moore@xxxxxxxxx>; Wysocki, Rafael J <rafael.j.wysocki@xxxxxxxxx>;
> Len Brown <lenb@xxxxxxxxxx>; devel@xxxxxxxxxx; Linux Kernel Mailing List
> <linux-kernel@xxxxxxxxxxxxxxx>
> Subject: Re: [PATCH v6 5/5] ACPICA: Remove PCI bits from ACPICA when
> CONFIG_PCI is unset
> 
> On Wed, Dec 12, 2018 at 8:34 PM Sinan Kaya <okaya@xxxxxxxxxx> wrote:
> >
> > On 12/12/2018 2:02 PM, Schmauss, Erik wrote:
> > >> ++ b/drivers/acpi/acpica/achware.h
> > >> @@ -109,8 +109,17 @@ acpi_hw_enable_runtime_gpe_block(struct
> > >> acpi_gpe_xrupt_info *gpe_xrupt_info,
> > > CONFIG_PCI is a Linux-ism. We should stay with the OS-independent
> > > nature of ACPICA. Please use ACPI_PCI_CONFIGURED and put it above
> the comment like so:
> > >
> > > #ifdef ACPI_PCI_CONFIGURED
> >
> > Thanks for the feedback. My search for ACPI_PCI_CONFIGURED returned
> nothing.
> >
> > git grep ACPI_PCI_CONFIGURED
> >
> > @Rafael,
> >
> > How do you want to handle this?
> 
> I think what Eric suggested is effectively to introduce a new ACPICA symbol.
> Erik?

Yes, that's correct and you can add something like

#ifdef CONFIG_PCI
#define ACPI_PCI_CONFIGURED
#endif

in include/linux/platform/aclinux.h to enable it. 




[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux