On Sat, Dec 8, 2018 at 10:47 PM Sinan Kaya <okaya@xxxxxxxxxx> wrote:
>
> Make PCI reboot conditional on PCI support being present on the kernel
> configuration.
>
> Signed-off-by: Sinan Kaya <okaya@xxxxxxxxxx>
Same comment as for patch [2/3]: make the subject say clearly that
this is about CONFIG_PCI.
> ---
> drivers/acpi/reboot.c | 12 +++++++++---
> 1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/acpi/reboot.c b/drivers/acpi/reboot.c
> index 6fa9c2a4cfe9..9aa367f098a6 100644
> --- a/drivers/acpi/reboot.c
> +++ b/drivers/acpi/reboot.c
> @@ -7,8 +7,6 @@
> void acpi_reboot(void)
> {
> struct acpi_generic_address *rr;
> - struct pci_bus *bus0;
> - unsigned int devfn;
> u8 reset_value;
>
> if (acpi_disabled)
> @@ -33,6 +31,11 @@ void acpi_reboot(void)
> * on a device on bus 0. */
> switch (rr->space_id) {
> case ACPI_ADR_SPACE_PCI_CONFIG:
> + {
> +#ifdef CONFIG_PCI
> + unsigned int devfn;
> + struct pci_bus *bus0;
> +
> /* The reset register can only live on bus 0. */
> bus0 = pci_find_bus(0, 0);
> if (!bus0)
> @@ -45,7 +48,10 @@ void acpi_reboot(void)
> pci_bus_write_config_byte(bus0, devfn,
> (rr->address & 0xffff), reset_value);
> break;
> -
> +#else
> + return;
Why not "break"?
> +#endif
> + }
> case ACPI_ADR_SPACE_SYSTEM_MEMORY:
> case ACPI_ADR_SPACE_SYSTEM_IO:
> printk(KERN_DEBUG "ACPI MEMORY or I/O RESET_REG.\n");
> --
