On Fri, Nov 30, 2018 at 12:06:52PM +0100, Wolfram Sang wrote: > > > > drivers/i2c/i2c-core-acpi.c | 41 ++++++++++++++++++++++++++----------- > > > > include/linux/acpi.h | 11 ++++++++++ > > > > > > Any reason this is not in i2c.h? > > > > Yes. As I explained earlier to some people there are facts affecting this: > > - the function is operate on top of solely ACPI structures > > And moving the function itself to the ACPI realm then? Unfortunately I don't see the place where it fits good. See below. > I don't say this is a show-stopper for this series, but I just wonder... > > > - there is already similar function for GPIO and it stays like that > > > > On top of this recently I've discovered, that i2c.h has separate #ifdef for I2C > > and ACPI which theoretically might produce a linker error in some cases. > > Is this something we have to live with or which can be cleaned up > somewhen? My opinion that we might need something like drivers/acpi/acpi_i2c_lib.c drivers/acpi/acpi_gpio_lib.c etc. But better to ask Rafael and Mika what they think about this. -- With Best Regards, Andy Shevchenko
