On Thu, Nov 29, 2018 at 07:34:40PM +0800, Hanjun Guo wrote: > On 2018/11/29 17:55, Lorenzo Pieralisi wrote: > > Running the Clang static analyzer on IORT code detected the following > > error: > > > > Logic error: Branch condition evaluates to a garbage value > > > > in > > > > iort_get_platform_device_domain() > > > > If the named component associated with a given device has no IORT > > mappings, iort_get_platform_device_domain() exits its MSI mapping loop > > with msi_parent pointer containing garbage, which can lead to erroneous > > code path execution. > > Not sure if we have such use cases that named component associated with > a given device has no IORT mappings, but this patch still make sense to > me, Yes, it is to make the kernel more robust against questionable (but valid) firmware bindings. Thanks, Lorenzo
