On Tue, Nov 06, 2018 at 04:46:41PM +0200, Andy Shevchenko wrote: > On Mon, Nov 05, 2018 at 05:59:28PM +0300, Heikki Krogerus wrote: > > Replacing struct property_set with the software nodes that > > were just introduced. > > > > The API and functionality for adding properties to devices > > remains the same, however, the goal is to convert the > > drivers to use the API for software nodes when the device > > has no real firmware node, and use the old API only when > > "extra" build-in properties are needed. > > It might be slightly easier to review if you preserve the ordering of > functions, i.e. device_add_properties() and device_remove_properties(). True, that change does not belong to this series. thanks, -- heikki