On Tue, Nov 06, 2018 at 08:13:03PM +0100, Borislav Petkov wrote: >On Mon, Oct 22, 2018 at 05:37:15PM +0800, Chao Fan wrote: >> kstrtoull() lives in 'uncompressed' period, used to >> convert a string to an unsigned long long. >> Copy to 'compressed' so that we can use it to >> convert the memory address from sting to unsigned > >sting? oops, typo, string. > >> long long in 'compressed' period. >> >> Signed-off-by: Chao Fan <fanc.fnst@xxxxxxxxxxxxxx> >> --- >> arch/x86/boot/compressed/misc.c | 88 +++++++++++++++++++++++++++++++++ >> arch/x86/boot/compressed/misc.h | 4 ++ >> 2 files changed, 92 insertions(+) > >Why do you need to copy things? > >You can link that file into compressed/ as lib/kstrtox.c is a library or >include it similar to what arch/x86/boot/compressed/cmdline.c does. > >Still better than copying the code. I will have a try, thanks for your suggestion. > >> diff --git a/arch/x86/boot/compressed/misc.h b/arch/x86/boot/compressed/misc.h >> index 008fdc47a29c..40378408d980 100644 >> --- a/arch/x86/boot/compressed/misc.h >> +++ b/arch/x86/boot/compressed/misc.h >> @@ -63,6 +63,10 @@ static inline void debug_puthex(const char *s) >> >> #endif >> >> +#if (defined CONFIG_RANDOMIZE_BASE) && (defined CONFIG_RANDOMIZE_BASE) > >CONFIG_RANDOMIZE_BASE twice huh? Once not enough? Sorry for that, the second should be CONFIG_MEMORY_HOTREMOVE. Thanks, Chao Fan > >:-) > >-- >Regards/Gruss, > Boris. > >Good mailing practices for 400: avoid top-posting and trim the reply. > >
