On Friday, October 19, 2018 1:03:41 PM CEST Andy Shevchenko wrote: > On Fri, Oct 19, 2018 at 10:41:28AM +0200, Hans de Goede wrote: > > This is necessary to avoid compilation issues on non x86 systems (where the > > asm/iosf_mbi.h header is not available) and on x86 systems in case IOSF_MBI > > support is not enabled there. > > > > Note that the AXP288 PMIC is connected through the LPSS i2c controller, so > > either we have IOSF_MBI support selected through the X86_INTEL_LPSS option, > > or we have a kernel where the OpRegion will never work anyways. > > Acked-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > > > > > Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx> > > --- > > drivers/acpi/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig > > index dd1eea90f67f..ac648d79f8ba 100644 > > --- a/drivers/acpi/Kconfig > > +++ b/drivers/acpi/Kconfig > > @@ -515,7 +515,7 @@ config CRC_PMIC_OPREGION > > > > config XPOWER_PMIC_OPREGION > > bool "ACPI operation region support for XPower AXP288 PMIC" > > - depends on MFD_AXP20X_I2C > > + depends on MFD_AXP20X_I2C && IOSF_MBI > > help > > This config adds ACPI operation region support for XPower AXP288 PMIC. > > > > Patch applied along with the series it is on top of. Thanks!