On 2018/10/26 3:24, Andrew Lunn wrote: > On Thu, Oct 25, 2018 at 06:09:15PM +0800, Wang Dongsheng wrote: >> Use "phy-handle" to porint an internal MDIO device port. > Hi Dongsheng > > You are basically defining how all future ACPI based MAC drivers get > access to their PHY. This needs to become part of the ACPI standard, > etc. > > This code should not be hidden away in the emac driver. It needs to be > placed somewhere public so other drivers can use it. And it needs good > documentation, including an example of what needs to go into the ACPI > tables, etc. Hi Andrew I saw AppliedMicro(apm) xgene has used "phy-handle" for ACPI method, so I guess "phy-handle" has become part of the ACPI standard. But I cannot make sure. I tried to confirm the property is defined in the document(Like DT binding). However, I did not find any documentation on the description property definition on the UEFI/ACPICA website. But when I was reading Documentation/acpi/DSD-properties-rules.txt, my understanding is we should try to conform to DT bindings. So maybe ACPI doesn't have such a document, just DT bindings. Cheers, Dongsheng > Thanks > Andrew >
