On Fri, Oct 12, 2018 at 8:01 PM Luck, Tony <tony.luck@xxxxxxxxx> wrote: > > Some new servers provide an interface so that the OS can ask the > BIOS to translate a system physical address to a memory address > (socket, memory controller, channel, rank, dimm, etc.). This is > useful for EDAC drivers that want to take the address of an error > reported in a machine check bank and let the user know which > DIMM may need to be replaced. > > Specification for this interface is available at: > > https://cdrdv2.intel.com/v1/dl/getContent/603354 > > [Based on earlier code by Qiuxu Zhuo <qiuxu.zhuo@xxxxxxxxx>] > > Tested-by: Qiuxu Zhuo <qiuxu.zhuo@xxxxxxxxx> > Signed-off-by: Tony Luck <tony.luck@xxxxxxxxx> > > --- > > Boris: > Add verb to first line commit description > Don't need #ifdef CONFIG_ACPI_ADXL guard any more > Comment for allocation of extra element for NULL terminator > Merge adxl_detect() into adxl_init() > > Tony: > Make couple of error messages more descriptive > --- > drivers/acpi/Kconfig | 10 ++ > drivers/acpi/Makefile | 3 + > drivers/acpi/acpi_adxl.c | 192 +++++++++++++++++++++++++++++++++++++++ > include/linux/adxl.h | 25 +++++ > 4 files changed, 230 insertions(+) > create mode 100644 drivers/acpi/acpi_adxl.c > create mode 100644 include/linux/adxl.h > > diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig > index dd1eea90f67f..327c93b51cb7 100644 > --- a/drivers/acpi/Kconfig > +++ b/drivers/acpi/Kconfig > @@ -498,6 +498,16 @@ config ACPI_EXTLOG > driver adds support for that functionality with corresponding > tracepoint which carries that information to userspace. > > +config ACPI_ADXL > + bool "Physical address to DIMM address translation" > + def_bool n > + help > + Enable interface that calls into BIOS using a DSM (device > + specific method) to convert system physical addresses > + to DIMM (socket, channel, rank, dimm, etc.). > + Only available on some servers. > + Used by newer EDAC drivers. > + Why is this user-selectable again? It wasn't in the previous iteration. Any reason to restore this? Thanks, Rafael