Hi Boris, On 12/10/2018 10:57, Borislav Petkov wrote: > On Fri, Sep 21, 2018 at 11:16:53PM +0100, James Morse wrote: >> To split up APEIs in_nmi() path, we need any nmi-like callers to always >> be in_nmi(). KVM shouldn't have to know about this, pull the RAS plumbing >> out into a header file. >> >> Currently guest synchronous external aborts are claimed as RAS >> notifications by handle_guest_sea(), which is hidden in the arch codes >> mm/fault.c. 32bit gets a dummy declaration in system_misc.h. >> >> There is going to be more of this in the future if/when we support >> the SError-based firmware-first notification mechanism and/or >> kernel-first notifications for both synchronous external abort and >> SError. Each of these will come with some Kconfig symbols and a >> handful of header files. >> >> Create a header file for all this. >> >> This patch gives handle_guest_sea() a 'kvm_' prefix, and moves the >> declarations to kvm_ras.h as preparation for a future patch that moves >> the ACPI-specific RAS code out of mm/fault.c. >> diff --git a/arch/arm/include/asm/kvm_ras.h b/arch/arm/include/asm/kvm_ras.h >> new file mode 100644 >> index 000000000000..aaff56bf338f >> --- /dev/null >> +++ b/arch/arm/include/asm/kvm_ras.h >> @@ -0,0 +1,14 @@ >> +// SPDX-License-Identifier: GPL-2.0 >> +// Copyright (C) 2018 - Arm Ltd > > checkpatch is complaining for some reason: > > WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 > #66: FILE: arch/arm/include/asm/kvm_ras.h:1: > +// SPDX-License-Identifier: GPL-2.0 Gah, I copied it from a C file, the comment-style has to be different for headers. Fixed, Thanks James
