On Tue, Sep 11, 2018 at 10:47:55AM +0200, Rafael J. Wysocki wrote: > > @@ -2134,9 +2134,11 @@ static int __pci_enable_wake(struct pci_dev *dev, pci_power_t state, bool enable > > > > /* > > * Bridges can only signal wakeup on behalf of subordinate devices, > > - * but that is set up elsewhere, so skip them. > > + * but that is set up elsewhere, so skip them. With the exception > > + * of bridges that we power manage. These can signal wake for > > + * example on a hotplug event. > > */ > > I would change the comment even more, to something like: > > "Bridges that are not power-manageable directly only signal wakeup on behalf > of subordinate devices which is set up elsewhere, so skip them. However, > bridges that are power-manageable may signal wakeup for themselves (for example, > on a hotplug event) and they need to be covered here." OK, I'll update the comment accordingly.
