On Tue, Sep 11, 2018 at 09:41:36AM +0200, Rafael J. Wysocki wrote: >On Tue, Sep 11, 2018 at 3:28 AM Chao Fan <fanc.fnst@xxxxxxxxxxxxxx> wrote: >> >> On Mon, Sep 10, 2018 at 10:13:49PM +0200, Rafael J. Wysocki wrote: >> >On Mon, Sep 10, 2018 at 2:41 PM Chao Fan <fanc.fnst@xxxxxxxxxxxxxx> wrote: >> >> >> >> Imitate the ACPI code of parsing ACPI tables to dig and read ACPI >> >> tables. >> > >> >Why? >> >> Sorry for that, I have sent the cover letter to you. > >Thanks, but please add the explanation here too. OK, I will add more. > >> > >> >> Since some operations are not needed here, >> > >> >What operations? >> >> Such as some operations related to the map between physical address >> and virtual address. Here in compressed period, use physical address >> directely. > >This information also needs to go into the changelog of the patch. Sorry for that. > >> > >> >> functions are simplified. Functions will be used to dig SRAT tables to get >> >> information of memory, so that KASLR can the memory in immovable node. >> > >> >So do you want to parse SRAT only or do something in addition to that? >> >> Only read and get memory information, won't change SRAT. >> So ACPI code will not be changed. > >I meant whether or not SRAT is the only table you need to look into. >If so, that also needs to be said in the patch changelog. Yes, you are right, here only SRAT table is needed. Thanks, Chao Fan > >Thanks, >Rafael > >