On Mon Sep 10 03:31, Rafael J. Wysocki wrote: > Sorry for the delayed response. No worries. Thanks for the review. > On Monday, July 2, 2018 7:44:02 PM CEST Curt Brune wrote: > > This change exposes ACPI device properties via sysfs under > > <device>/firmware_node/properties/*. This is a logical extension of > > the changes that expose _ADR, _STR, _HID, etc... in the same > > directory. [snip] > > diff --git a/Documentation/acpi/dsd/sysfs-properties.txt b/Documentation/acpi/dsd/sysfs-properties.txt > > Could you instead or in addition to this document the new sysfs attributes > under Documentation/ABI/testing/ ? Sure thing. It seems a little weird to document it in two places, so I will put it under Documentation/ABI/testing/ as you suggest. > > diff --git a/drivers/acpi/device_sysfs.c b/drivers/acpi/device_sysfs.c > > index 24418932612e..5e98bc5015ab 100644 > > --- a/drivers/acpi/device_sysfs.c > > +++ b/drivers/acpi/device_sysfs.c > > There are no comments in the code you're adding to this file and some pieces of > it are not entirely obvious. Care to document what's going on? > > At least the data structures used should be described. Yes, no problem. Cheers, Curt
