On Thu, Sep 06, 2018 at 11:27:26AM -0000, D. J. Bernstein wrote: > --- a/drivers/acpi/acpica/hwxface.c 2018-07-31 21:14:22.759000000 +0200 > +++ b/drivers/acpi/acpica/hwxface.c 2018-08-01 01:48:01.087000000 +0200 > @@ -44,6 +44,7 @@ > #define EXPORT_ACPI_INTERFACES > > #include <acpi/acpi.h> > +#include <linux/dmi.h> > #include "accommon.h" > #include "acnamesp.h" The ACPI Component Architecture is an OS-independent project which is downstreamed into the Linux kernel. Hence inclusion of Linux- specific headers isn't appropriate in drivers/acpi/acpica and that may be the reason why the patch was ignored on their mailing list. The DMI quirk and the command line parameter would have to live outside that directory. I'm not really familiar with ACPI system sleep code but a quick look at drivers/acpi/sleep.c shows there's already a table of DMI quirks present which might lend itself to amending it with a quirk to force S3. Whether or not that quirk is acceptable for ACPI maintainers I don't know. > I'm watching the list so please don't cc me on replies.] Hm, that's an unusual request, everybody uses group-reply on kernel mailing lists. HTH, Lukas
