Re: [PATCH v2] i2c: designware: Remove Cherry Trail PMIC I2C bus pm_disabled workaround

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 08/31/2018 10:17 AM, Andy Shevchenko wrote:
On Thu, Aug 30, 2018 at 11:05:41PM +0200, Wolfram Sang wrote:
On Wed, Aug 29, 2018 at 05:27:53PM +0200, Hans de Goede wrote:
Commit a3d411fb38c0 ("i2c: designware: Disable pm for PMIC i2c-bus even if
there is no _SEM method"), always set the pm_disabled flag on the I2C7
controller, even if its bus was not shared with the PUNIT.

This was a workaround for various suspend/resume issues, after the
following 2 commits this workaround is no longer necessary:

Commit 541527728341 ("PM: i2c-designware-platdrv: Suspend/resume at the
                      late/early stages")
Commit e6ce0ce34f65 ("ACPI / LPSS: Add device link for CHT SD card
                      dependency on I2C")

Therefor this commit removes this workaround.

After this commit the pm_disabled flag is only used to indicate that the
bus is shared with the PUNIT and after other recent changes we no longer
call dev_pm_syscore_device(dev, true), so we are no longer actually
disabling (non-runtime) pm, so this commit also renames the flag to
shared_with_punit to better reflect what it is for.

Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>

Waiting for tags here... I assume it is OK to have applied patch 1/2
from the previous series independently of this patch?

I'm fine with it
Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

Oh I didn't notice yesterday there was already v2 of this patch. I have here a Cherry Trail without _SEM method and after this patch 808622C1:06 is runtime power managed but didn't see any issue at quick test.

Acked-by: Jarkko Nikula <jarkko.nikula@xxxxxxxxxxxxxxx>



[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux