Re: [RESEND PATCH v2] acpi/processor: Fix the return value of acpi_processor_ids_walk()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Dou,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on pm/linux-next]
[also build test ERROR on v4.18 next-20180822]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Dou-Liyang/acpi-processor-Fix-the-return-value-of-acpi_processor_ids_walk/20180823-165002
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
config: x86_64-randconfig-r0-08231341 (attached as .config)
compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   In file included from include/acpi/acpi.h:29:0,
                    from include/linux/acpi.h:34,
                    from drivers/acpi/acpi_processor.c:16:
   drivers/acpi/acpi_processor.c: In function 'acpi_processor_ids_walk':
>> include/acpi/acoutput.h:391:19: error: implicit declaration of function 'acpi_ut_status_exit' [-Werror=implicit-function-declaration]
     ACPI_TRACE_EXIT (acpi_ut_status_exit, acpi_status, status)
                      ^
   include/acpi/acoutput.h:274:44: note: in definition of macro 'ACPI_DO_WHILE0'
    #define ACPI_DO_WHILE0(a)               do a while(0)
                                               ^
   include/acpi/acoutput.h:391:2: note: in expansion of macro 'ACPI_TRACE_EXIT'
     ACPI_TRACE_EXIT (acpi_ut_status_exit, acpi_status, status)
     ^~~~~~~~~~~~~~~
   drivers/acpi/acpi_processor.c:646:3: note: in expansion of macro 'return_ACPI_STATUS'
      return_ACPI_STATUS(status);
      ^~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors
--
   In file included from include/acpi/acpi.h:29:0,
                    from include/linux/acpi.h:34,
                    from drivers//acpi/acpi_processor.c:16:
   drivers//acpi/acpi_processor.c: In function 'acpi_processor_ids_walk':
>> include/acpi/acoutput.h:391:19: error: implicit declaration of function 'acpi_ut_status_exit' [-Werror=implicit-function-declaration]
     ACPI_TRACE_EXIT (acpi_ut_status_exit, acpi_status, status)
                      ^
   include/acpi/acoutput.h:274:44: note: in definition of macro 'ACPI_DO_WHILE0'
    #define ACPI_DO_WHILE0(a)               do a while(0)
                                               ^
   include/acpi/acoutput.h:391:2: note: in expansion of macro 'ACPI_TRACE_EXIT'
     ACPI_TRACE_EXIT (acpi_ut_status_exit, acpi_status, status)
     ^~~~~~~~~~~~~~~
   drivers//acpi/acpi_processor.c:646:3: note: in expansion of macro 'return_ACPI_STATUS'
      return_ACPI_STATUS(status);
      ^~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +/acpi_ut_status_exit +391 include/acpi/acoutput.h

0377b5ac Bob Moore 2012-12-31  383  
0377b5ac Bob Moore 2012-12-31  384  #define return_VOID \
0377b5ac Bob Moore 2012-12-31  385  	ACPI_DO_WHILE0 ({ \
0377b5ac Bob Moore 2012-12-31  386  		acpi_ut_exit (ACPI_DEBUG_PARAMETERS); \
0377b5ac Bob Moore 2012-12-31  387  		return; \
0377b5ac Bob Moore 2012-12-31  388  	})
0377b5ac Bob Moore 2012-12-31  389  
0377b5ac Bob Moore 2012-12-31  390  #define return_ACPI_STATUS(status) \
fd1af712 Bob Moore 2013-03-08 @391  	ACPI_TRACE_EXIT (acpi_ut_status_exit, acpi_status, status)
0377b5ac Bob Moore 2012-12-31  392  

:::::: The code at line 391 was first introduced by commit
:::::: fd1af7126fb62688cfcf4b563c73b2909ac30f74 ACPICA: Regression fix: reinstate safe exit macros

:::::: TO: Bob Moore <robert.moore@xxxxxxxxx>
:::::: CC: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux