On 08/15/2018 03:55 AM, Rafael J. Wysocki wrote: > On Wed, Aug 15, 2018 at 8:44 AM Jan Beulich <JBeulich@xxxxxxxx> wrote: >>>>> On 25.06.18 at 12:17, wrote: >>> This is unnecessary and triggers a warning in the hypervisor. >>> >>> Often systems have more processor entries in their ACPI tables than are >>> actually installed/active. The ACPI_STA_DEVICE_PRESENT bit cannot be >>> reliably used, but the ACPI_MADT_ENABLED bit can. In order to not >>> introduce new functions in the main ACPI processor driver code, simply >>> use acpi_get_phys_id(), which does more than we need, but which checks >>> the MADT enabled bit in the process. Any CPU for which we can't >>> determine the APIC ID is unlikely to work properly anyway, so the extra >>> checks done by acpi_get_phys_id() should do no harm. >>> >>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx> >>> --- >>> drivers/acpi/processor_core.c | 1 + >>> drivers/xen/xen-acpi-processor.c | 6 ++++++ >>> 2 files changed, 7 insertions(+) >> With Jürgen's R-b in place, may I ask for an ack for the processor_core.c >> change, or - in case you dislike the new export - an alternative suggestion? > It is fine to export it IMO. If you need my ACK for that, please feel > free to add it to the patch. Applied to for-linus-4.19. -boris
