On Sat, Aug 11, 2018 at 10:18 AM Paul Menzel
<pmenzel+linux-acpi@xxxxxxxxxxxxx> wrote:
>
> Dear Rafael,
>
>
> Am 10.08.2018 um 10:02 schrieb Rafael J. Wysocki:
> > On Friday, August 10, 2018 12:33:43 AM CEST Paul Menzel wrote:
>
> >> Your commit 18996f2d (ACPICA: Events: Stop unconditionally clearing ACPI
> >> IRQs during suspend/resume) caused a regression on the ASRock E350M1
> >> with coreboot. I reported bug #200691 [1], but didn’t get a response
> >> yet. In case it was overlooked, I am writing this email.
> >>
> >> It’d be awesome, if the regression could be solved.
> >
> > Please check if the patch below (on top of the current mainline) makes any
> > difference.
> >
> > ---
> > drivers/acpi/acpica/hwsleep.c | 11 +++--------
> > 1 file changed, 3 insertions(+), 8 deletions(-)
> >
> > Index: linux-pm/drivers/acpi/acpica/hwsleep.c
> > ===================================================================
> > --- linux-pm.orig/drivers/acpi/acpica/hwsleep.c
> > +++ linux-pm/drivers/acpi/acpica/hwsleep.c
> > @@ -56,14 +56,9 @@ acpi_status acpi_hw_legacy_sleep(u8 slee
> > if (ACPI_FAILURE(status)) {
> > return_ACPI_STATUS(status);
> > }
> > - /*
> > - * If the target sleep state is S5, clear all GPEs and fixed events too
> > - */
> > - if (sleep_state == ACPI_STATE_S5) {
> > - status = acpi_hw_clear_acpi_status();
> > - if (ACPI_FAILURE(status)) {
> > - return_ACPI_STATUS(status);
> > - }
> > + status = acpi_hw_clear_acpi_status();
> > + if (ACPI_FAILURE(status)) {
> > + return_ACPI_STATUS(status);
> > }
> > acpi_gbl_system_awake_and_running = FALSE;
>
> Thank you for the patch. With this patch applyied to Linux master
> branch, I am *unable* to reproduce the issue.
>
> Tested-by: Paul Menzel <pmenzel@xxxxxxxxxxxxx>
Thanks!
I'll resend it with a changelog then and will queue it up.
