Re: [PATCH 02/11] ACPICA: ACPICA: add status check for acpi_hw_read before assigning return value

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Aug 10, 2018 at 11:44 PM Erik Schmauss <erik.schmauss@xxxxxxxxx> wrote:
>
> Reported-by: Mark Gross <mark.gross@xxxxxxxxx>
> Signed-off-by: Erik Schmauss <erik.schmauss@xxxxxxxxx>

It looks like this should be propagated to "stable" kernels.  If so,
then all of them or just 4.17.y and newer?

> ---
>  drivers/acpi/acpica/hwregs.c | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/acpi/acpica/hwregs.c b/drivers/acpi/acpica/hwregs.c
> index 3de794bcf8fa..69603ba52a3a 100644
> --- a/drivers/acpi/acpica/hwregs.c
> +++ b/drivers/acpi/acpica/hwregs.c
> @@ -528,13 +528,18 @@ acpi_status acpi_hw_register_read(u32 register_id, u32 *return_value)
>
>                 status =
>                     acpi_hw_read(&value64, &acpi_gbl_FADT.xpm2_control_block);
> -               value = (u32)value64;
> +               if (ACPI_SUCCESS(status)) {
> +                       value = (u32)value64;
> +               }
>                 break;
>
>         case ACPI_REGISTER_PM_TIMER:    /* 32-bit access */
>
>                 status = acpi_hw_read(&value64, &acpi_gbl_FADT.xpm_timer_block);
> -               value = (u32)value64;
> +               if (ACPI_SUCCESS(status)) {
> +                       value = (u32)value64;
> +               }
> +
>                 break;
>
>         case ACPI_REGISTER_SMI_COMMAND_BLOCK:   /* 8-bit access */
> --
> 2.17.1
>



[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux