Re: [PATCH] ACPI / EC: Add another entry for Thinkpad X1 Carbon 6th

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wednesday, August 8, 2018 11:50:37 AM CEST Mika Westerberg wrote:
> Commit 2c4d6baf1bc4 ("ACPI / EC: Use ec_no_wakeup on more Thinkpad X1
> Carbon 6th systems") changed the DMI table to match all systems where
> DMI product family is "Thinkpad X1 Carbon 6th". However, the system I
> have here has this string written differently (ThinkPad vs. Thinkpad)
> which makes the match fail.
> 
> In addition to that, after BIOS upgrade Robin now has the same string
> than my system has (perhaps newer BIOS has changed the string).
> 
> In any case add another DMI entry to acpi_ec_no_wakeup[] table hopefully
> covering all the X1 Carbon 6th systems out there.
> 
> Fixes: 2c4d6baf1bc4 ("ACPI / EC: Use ec_no_wakeup on more Thinkpad X1 Carbon 6th systems")
> Cc: Robin H. Johnson <robbat2@xxxxxxxxxx>
> Signed-off-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
> ---
>  drivers/acpi/ec.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
> index 917f77f4cb55..a2f569e19610 100644
> --- a/drivers/acpi/ec.c
> +++ b/drivers/acpi/ec.c
> @@ -2045,6 +2045,13 @@ static const struct dmi_system_id acpi_ec_no_wakeup[] = {
>  			DMI_MATCH(DMI_PRODUCT_FAMILY, "Thinkpad X1 Carbon 6th"),
>  		},
>  	},
> +	{
> +		.ident = "Thinkpad X1 Carbon 6th",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> +			DMI_MATCH(DMI_PRODUCT_FAMILY, "ThinkPad X1 Carbon 6th"),
> +		},
> +	},
>  	{ },
>  };
>  
> 

I've applied this but I've changed the ident field to match the
product family string below.

Cheers,
Rafael

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux