Re: [PATCH] acpi/ec: Use ec_no_wakeup on more Thinkpad X1 Carbon 6th systems

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Aug 7, 2018 at 3:16 PM, Mika Westerberg
<mika.westerberg@xxxxxxxxxxxxxxx> wrote:
> On Fri, Jul 13, 2018 at 08:50:47PM +0000, Robin H. Johnson wrote:
>> The ec_no_wakeup matcher added for Thinkpad X1 Carbon 6th gen systems
>> beyond matched only a single DMI model (20KGS3JF01), that didn't cover
>> my laptop (20KH002JUS). Change to match based on DMI product family to
>> cover all X1 6th gen systems.
>>
>> Signed-off-by: Robin H. Johnson <robbat2@xxxxxxxxxx>
>> ---
>>  drivers/acpi/ec.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
>> index 442a9e24f439..917f77f4cb55 100644
>> --- a/drivers/acpi/ec.c
>> +++ b/drivers/acpi/ec.c
>> @@ -2042,7 +2042,7 @@ static const struct dmi_system_id acpi_ec_no_wakeup[] = {
>>               .ident = "Thinkpad X1 Carbon 6th",
>>               .matches = {
>>                       DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
>> -                     DMI_MATCH(DMI_PRODUCT_NAME, "20KGS3JF01"),
>> +                     DMI_MATCH(DMI_PRODUCT_FAMILY, "Thinkpad X1 Carbon 6th"),
>
> This causes problem on my laptop because DMI_PRODUCT_FAMILY on that
> system returns "ThinkPad X1 Carbon 6th" (Pad vs. pad). Can you share
> output of dmidecode from your system? Maybe we can find some common
> identifier there that works for both.

Or we can add one more entry to the table I guess. :-)
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux