On Thu, 2018-08-02 at 15:39 +0200, Lukas Wunner wrote:
> On Thu, Aug 02, 2018 at 04:04:11PM +0300, Andy Shevchenko wrote:
> > Switch to bitmap_zalloc() to show clearly what we are allocating.
> > Besides that it returns pointer of bitmap type instead of opaque
> > void *.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
>
> Indeed this is much nicer, thanks!
>
> Reviewed-by: Lukas Wunner <lukas@xxxxxxxxx>
>
>
> > - requires immutable branch [1] to be pulled first
> > [1]: git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git
> > ib/4.17-bitmap
>
+Cc: Dmitry
> The topmost commit on that branch says that static inline couldn't
> be used because of circular dependencies. I'm wondering if using
> #define instead of static inline would've been possible.
Probably. You mean something like we have for IO accessors
#ifndef bitmap_alloc
#define bitmap_alloc bitmap_alloc
static inline void *bitmap_alloc(...)
{
...
}
#endif
?
I guess you may still have time to submit a patch.
--
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
