Hi *, the code used in the asus-wmi module doesn't work anymore on new Asus laptops like the UX550GE. I used the new devids for the CPU and GPU fans to make them both appear in sysfs but before submitting this patch I need some help about how to manage the sysfs/fans interaction. Specifically, it is not possible to control the speed of the fans using the new devids. The fans start in "auto" mode, can only be put into "full_on" mode, and back. Right now I implemented a simplified behavior for the pwm files: writing 0 to them means "auto" while any value from 1 to 255 means "full_on". I don't know how other parts of the system use the value in pwm so I don't have a clear idea about how to map 256 values to the full_on/auto states. Should the pwm files be there at all? Also, to keep track of which method use for the fans I added a flag to the main asus_wmi struct. Is this the correct way to proceed? Is it better to add a new quirk for the UX550 that will be re-used for other models in the future if necessary? This is my first patch to the Linux kernel - help and comments are hightly apreciated. Many thanks. federico -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
