Hi All, Thanks for the feedback. On Wed Jun 27 04:58, Rafael J. Wysocki wrote: > On Wednesday, June 27, 2018 1:42:08 PM CEST Sakari Ailus wrote: > > Hi Curt, others, > > > > On Fri, Jun 22, 2018 at 10:27:55AM -0700, Curt Brune wrote: > > > Hello - > > > > > > I am looking into exporting acpi _DSD properties to sysfs by updating > > > acpi_device_setup_files() in drivers/acpi/scan.c. I need some advice. > > > > > > > Thanks for bringing this up. > > > > I suppose it's the change of the return value from -ENODEV in 51858a277 > > that's the real issue? > > > > One option could be to revert to the approach I had with v2 of the patch, > > i.e. handle the conversion from ACPI specific return codes in > > fwnode_property_get_reference_args() instead. This could be done for all > > return codes or just for -ENODEV (I think I'd prefer that, as this is a > > very specific use case that likely doesn't exist ). > > > > Mika, Rafael, any opinion? > > Not really, please do what you think is the most appropriate. I took an alternate approach, where I defer all properties of types ACPI_TYPE_PACKAGE and ACPI_TYPE_LOCAL_REFERENCE without depending on the return code of __acpi_node_get_property_reference(). Deferring the sysfs node creation for these types until acpi_bus_scan() is working fine now. I will be sending a patch with the details shortly. Cheers, Curt -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
