Re: [PATCH v2 8/9] Bluetooth: hci_h5: Add support for the RTL8723BS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jeremy,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on bluetooth-next/master]
[also build test ERROR on v4.17 next-20180615]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Hans-de-Goede/Bluetooth-Add-RTL8723BS-support/20180617-024339
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git master
config: i386-randconfig-x007-201824 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   drivers/bluetooth/hci_h5.c: In function 'h5_btrtl_setup':
>> drivers/bluetooth/hci_h5.c:835:14: error: too many arguments to function 'btrtl_initialize'
     btrtl_dev = btrtl_initialize(h5->hu->hdev, h5->id);
                 ^~~~~~~~~~~~~~~~
   In file included from drivers/bluetooth/hci_h5.c:33:0:
   drivers/bluetooth/btrtl.h:70:41: note: declared here
    static inline struct btrtl_device_info *btrtl_initialize(struct hci_dev *hdev)
                                            ^~~~~~~~~~~~~~~~
   At top level:
   drivers/bluetooth/hci_h5.c:892:36: warning: 'h5_serdev_driver' defined but not used [-Wunused-variable]
    static struct serdev_device_driver h5_serdev_driver = {
                                       ^~~~~~~~~~~~~~~~

vim +/btrtl_initialize +835 drivers/bluetooth/hci_h5.c

   824	
   825	static int h5_btrtl_setup(struct h5 *h5)
   826	{
   827		struct btrtl_device_info *btrtl_dev;
   828		struct sk_buff *skb;
   829		__le32 baudrate_data;
   830		u32 device_baudrate;
   831		unsigned int controller_baudrate;
   832		bool flow_control;
   833		int err;
   834	
 > 835		btrtl_dev = btrtl_initialize(h5->hu->hdev, h5->id);
   836		if (IS_ERR(btrtl_dev))
   837			return PTR_ERR(btrtl_dev);
   838	
   839		err = btrtl_get_uart_settings(h5->hu->hdev, btrtl_dev,
   840					      &controller_baudrate, &device_baudrate,
   841					      &flow_control);
   842		if (err)
   843			goto out_free;
   844	
   845		baudrate_data = cpu_to_le32(device_baudrate);
   846		skb = __hci_cmd_sync(h5->hu->hdev, 0xfc17, sizeof(baudrate_data),
   847				     &baudrate_data, HCI_INIT_TIMEOUT);
   848		if (IS_ERR(skb)) {
   849			bt_dev_err(h5->hu->hdev, "set baud rate command failed");
   850			err = PTR_ERR(skb);
   851			goto out_free;
   852		} else {
   853			kfree_skb(skb);
   854		}
   855		/* Give the device some time to set up the new baudrate. */
   856		usleep_range(10000, 20000);
   857	
   858		serdev_device_set_baudrate(h5->hu->serdev, controller_baudrate);
   859		serdev_device_set_flow_control(h5->hu->serdev, flow_control);
   860	
   861		err = btrtl_download_firmware(h5->hu->hdev, btrtl_dev);
   862		/* Give the device some time before the hci-core sends it a reset */
   863		usleep_range(10000, 20000);
   864	
   865	out_free:
   866		btrtl_free(btrtl_dev);
   867	
   868		return err;
   869	}
   870	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux