On Tue, May 22, 2018 at 3:38 PM, Alex G. <mr.nuke.me@xxxxxxxxx> wrote: > > > On 05/22/2018 03:55 AM, Rafael J. Wysocki wrote: >> On Mon, May 21, 2018 at 3:49 PM, Alexandru Gagniuc <mr.nuke.me@xxxxxxxxx> wrote: >>> ghes_severity() is a misnomer in this case, as it implies the severity >>> of the entire GHES structure. Instead, it maps one CPER value to a >>> GHES_SEV* value. ghes_cper_severity() is clearer. >> >> It looks like the *real* reason for this change is that you >> re-introduce ghes_severity() as a different function in the second >> patch. > > /me holds fist at Borislav > >> There are a couple of reasons to avoid that, one of them being that >> people will now have to remember what the function did in which kernel >> versions. > > So? > >> Also, the current name is good enough IMO, > > Two other reviewers were extremely confused by the vague name, so no, > this is not good enough. Of course, you are free to have a differing opinion and I don't have to convince you about my point. You need to convince me about your point to get the patch in through my tree, which you haven't done so far. >> so I'm not going to apply this patch. -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
