Re: [PATCH 0/9] ACPI/i2c Enumerate several instances out of one fwnode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/20/2018 06:23 PM, Jonathan Cameron wrote:
> On Sun, 20 May 2018 15:28:48 +0200
> Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
> 
>> Hi All,
>>
>> This series really consists of 2 series, patches 1-5 add support for
>> interesting ACPI tables which describe multiple i2c chips in a single
>> fwnode, sometimes multiple cases of the same chip on different addresses,
>> sometimes a bunch of related chips.
>>
>> Andy Shevchenko has come up with the solution of adding a quirk based
>> on the ACPI HID of the fwnode for these devices which makes the
>> drivers/i2c/i2c-core-acpi.c code instantiate separate i2c_client devices
>> for each I2cSerialBusV2 in the fwnode. I agree with him that this is
>> the best (least ugly) solution for this.
>>
>> I've been testing this solution on a device if mine which needs a solution
>> for this, the HP Pavilion x2 - 10-n000nd 2-in-1 has an acpi_device / fwnode
>> with a HID of BSG1160 which describes 3 different i2c sensors in an accel /
>> magneto / gyro sensor cluster on the tablet. This has let to some extra
>> prep. patches and some fixes to Andy's patches.
>>
>> Patches 6-9 use the new functionality creating  one i2c-client per
>> I2cSerialBusV2 resource to make the sensor cluster on the HP X2 work and
>> are posted as part of this series to show how this functionality can be
>> used.
>>
>> Assuming everyone is ok with this series (I'm not expecting anyone to be
>> really happy about the need for this), then I suggest that patches 1-6
>> get merged togther through either the ACPI or the i2c tree, I guess the
>> i2c tree would make somewhat more sense, since most patches are there.
>>
>> Then once those are accepted patches 7-9 can be merged into the iio tree,
>> there is no compile time dependency between the 2, so these can be merged
>> separately. Note merging 7-9 before there is agreement that this is the
>> right way to fix this is probably not a good idea.
> 
> It's hideous, but I can live with it as better than anything else anyone
> has come up with.  I just hope we don't get a huge number of these
> 'interesting' ACPI cases going forwards.

It's ACPI, you know this is just the beginning ;)

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux