On 05/11/2018 11:02 AM, Borislav Petkov wrote: > On Fri, May 11, 2018 at 10:54:09AM -0500, Alex G. wrote: >> That being clarified, should I replace "crackmonkey" with "broken" in >> the commit message? > > Keep your opinion *outside* of commit messages - their goal is to > explain *why* the change is being made in strictly technical language so > that when someone looks at git history, someone can know *why*. > >> Borislav, I sense some confusion. AER is not a "reporting" driver. It >> handles the errors. You can't leave these errors unhandled. They >> propagate to the root complex and can cause fatal MCEs when not handled. >> The window to handle the error is pretty large, so it's not a concern >> when you're handling it. > > I think *you* didn't get it: IS_ENABLED(CONFIG_ACPI_APEI_PCIEAER) is not > enough of a check to confirm that there actually *is* an AER driver to > handle the errors. If you really want to make sure the driver is loaded > and functioning, then you need an explicit registering mechanism or some > other way of checking it really is there and handling errors. config ACPI_APEI_PCIEAER bool "APEI PCIe AER logging/recovering support" depends on ACPI_APEI && PCIEAER help PCIe AER errors may be reported via APEI firmware first mode. Turn on this option to enable the corresponding support. PCIAER is not modularizable. QED Alex -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
