Hi Alex, > -----Original Message----- > From: Alexandru Gagniuc [mailto:mr.nuke.me@xxxxxxxxx] > Sent: 30 April 2018 22:34 > To: bp@xxxxxxxxx > Cc: alex_gagniuc@xxxxxxxxxxxx; austin_bolen@xxxxxxxx; > shyam_iyer@xxxxxxxx; Alexandru Gagniuc; Rafael J. Wysocki; Len Brown; > Tony Luck; Mauro Carvalho Chehab; Robert Moore; Erik Schmauss; Tyler > Baicar; Will Deacon; James Morse; Shiju Jose; Jonathan (Zhixiong) Zhang; > gengdongjiu; linux-acpi@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > linux-edac@xxxxxxxxxxxxxxx; devel@xxxxxxxxxx > Subject: [RFC PATCH v4 2/3] acpi: apei: Rename ghes_severity() to > ghes_cper_severity() > > ghes_severity() is a misnomer in this case, as it implies the severity > of the entire GHES structure. Instead, it maps one CPER value to a > monotonically increasing number. ghes_cper_severity() is clearer. > > Signed-off-by: Alexandru Gagniuc <mr.nuke.me@xxxxxxxxx> > --- > drivers/acpi/apei/ghes.c | 17 ++++++++--------- > 1 file changed, 8 insertions(+), 9 deletions(-) > > diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c > index f9b53a6f55f3..c9f1971333c1 100644 > --- a/drivers/acpi/apei/ghes.c > +++ b/drivers/acpi/apei/ghes.c > @@ -271,7 +271,7 @@ static void ghes_fini(struct ghes *ghes) > unmap_gen_v2(ghes); > } > > -static inline int ghes_severity(int severity) > +static inline int ghes_cper_severity(int severity) [...] > else > ratelimit = &ratelimit_uncorrected; > @@ -705,9 +705,8 @@ static int ghes_proc(struct ghes *ghes) > if (rc) > goto out; > > - if (ghes_severity(ghes->estatus->error_severity) >= > GHES_SEV_PANIC) { > + if (ghes_cper_severity(ghes->estatus->error_severity) >= > GHES_SEV_PANIC) > __ghes_panic(ghes); PCIe AER fatal errors result panic here. I think ghes_cper_severity to be replaced with ghes_severity in the ghes_proc function as well in the patch "acpi: apei: Do not panic() on PCIe errors reported through GHES"? > - } > [...] > 2.14.3 Thanks, Shiju -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
