Re: [PATCH] ACPI / watchdog: Initialize before PNP

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Apr 19, 2018 at 01:08:37PM +0300, Mika Westerberg wrote:
> At least on one Dell system the PNP motherboard resources device
> includes resources used by WDAT table. Since PNP gets initialized before
> WDAT it results following error and no watchdog:
> 
>   platform wdat_wdt: failed to claim resource 3: [io  0x046a-0x046c]
>   ACPI: watchdog: Device creation failed: -16
> 
> Now, the PNP system driver is already accustomed with the situation that
> it cannot reserve all those motherboard resources because drivers using
> those might have reserved them already. In addition putting WDAT table
> resources under motherboard resources device makes sense in general.
> 
> Fix this by initializing WDAT right before PNP. This allows WDAT to
> reserve all its resources and still keeps PNP system driver happy.
> 
> Reported-by: Shubhrata.Priyadarsh@xxxxxxxx
> Reported-by: Takashi Iwai <tiwai@xxxxxxx>
> Signed-off-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>

Acked-by: Guenter Roeck <linux@xxxxxxxxxxxx>

> ---
>  drivers/acpi/scan.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c
> index cc234e6a6297..970dd87d347c 100644
> --- a/drivers/acpi/scan.c
> +++ b/drivers/acpi/scan.c
> @@ -2166,10 +2166,10 @@ int __init acpi_scan_init(void)
>  	acpi_cmos_rtc_init();
>  	acpi_container_init();
>  	acpi_memory_hotplug_init();
> +	acpi_watchdog_init();
>  	acpi_pnp_init();
>  	acpi_int340x_thermal_init();
>  	acpi_amba_init();
> -	acpi_watchdog_init();
>  	acpi_init_lpit();
>  
>  	acpi_scan_add_handler(&generic_device_handler);
> -- 
> 2.17.0
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux