[PATCH 0/2] ACPI / AC + Battery: Add quirk to avoid checking for PMIC with native driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi All,

I found another laptop which uses an AXP288 PMIC, but does not use the
builtin fuel-gauge. Here is a reworked version of Carlo Caione's patches
to ignore the PMIC-with-native-driver blacklist in the ACPI AC / Battery
code.

Note this version applies on top of my recent patch series:

[PATCH 1/4] ACPI / AC: Remove initializer for unused ident dmi_system_id
[PATCH 2/4] ACPI / battery: Remove initializer for unused ident dmi_system_id
[PATCH 3/4] ACPI / battery: Add handling for devices which wrongly report discharging state
[PATCH 4/4] ACPI / battery: Ignore AC state in handle_discharging on systems where it is broken

This v3 has the following changes compared to Carlo's last version (v2):
-Rebased on top of 4.17-rc1 + the above patches
-Redo the patch split putting all changes to 1 file in a single commit
-Add a second dmi entry for the Lenovo Ideapad Miix 320

I realize this aint pretty, but there really is no other way:

a) We need a native fuel-gauge driver because some devices use the AXP288
PMIC's fuel-gauge functionality and don't define any PNP0C0A at all.

b) Some devices do define a PNP0C0A so we get duplicate
/sys/class/power_supply entries, so we need to filter out one or the other.

c) Most devices which use the AXP288 fuel-gauge function and define a
PNP0C0A ACPI device rely on custom opregions related to a virtual INT33FE
device for which we've no documentation, so we've chosen to filter out
the PNP0C0A power-supply functionality on devices with an AXP288 and
always use the existing (and necessary, see a.) fuel-gauge driver rather
then spending time on figuring out the custom opregions.

d) But now we see devices which use the AXP288 PMIC, which presence the
AC / battery driver check for to filter themselves out, but which don't
use the fuel-gauge function of the AXP288, so we do actually need the
PNP0C0A device there.

Which leads to these patches using DMI quirks to handle case d.  :|

Regards,

Hans


p.s.

Carlo, I've a different approach for not registering the non-functional
AXP288 fuel-gauge power-supply class device, I will Cc you on those patches
too, please let me know if those also work on the ECS EF20EA laptop.

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux