On April 12, 2018 10:14:01 AM GMT+02:00, Hans de Goede <hdegoede@xxxxxxxxxx> wrote: >Hi, > >On 11-04-18 19:47, Daniel Drake wrote: >> On Wed, Apr 11, 2018 at 11:42 AM, Hans de Goede <hdegoede@xxxxxxxxxx> >wrote: >>> Either way userspace regressions are a big no-no and there are >enough >>> people running new kernels with an old(ish) userspace for this to be >>> a real problem, so we really need to go with FULL for now. >> >> Would it be a regression though? According to your analysis userspace >> is already reporting an inaccurate state. > >Hmm, you are right, so if we do the right thing and resort >NOT_CHARGING then upower will end up reporting UNKNOWN to >the desktop environment instead of the current DISCHARGING, >which is a small improvement already, although some may see >this as a regression. My patch was reverted because Rafael treated that as regression. A lot of people see that as regression. > >So I've just checked what GNOME3 does with upower translating >the "not charging" or in upower terms "pending-charge" for the >BATC device to "unknown" for the display device which is what >most DE-s use. This results in a battery icon with a ? inside >it being shown, which is actually an improvement over the >discharging icon shown before. > >And you are right, that since currently we are reporting discharging >in this case, which certainly is wrong, this is not a regression. > >So I will do a v2 of this patch-set switching to NOT_CHARGING >so that we fix this correctly in one go > >Regards, > >Hans -- Sent from my Android device with K-9 Mail. Please excuse my brevity. -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
