Hi Mario, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.16-rc7 next-20180328] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Mario-Limonciello/power-hibernate-Make-passing-hibernate-offsets-more-friendly/20180328-212230 config: i386-randconfig-x006-201812 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): kernel/power/hibernate.c: In function 'resume_offset_show': kernel/power/hibernate.c:1067:25: warning: format '%lu' expects argument of type 'long unsigned int', but argument 3 has type 'sector_t {aka long long unsigned int}' [-Wformat=] return sprintf(buf, "%lu\n", swsusp_resume_block); ~~^ %llu kernel/power/hibernate.c: In function 'resume_offset_store': >> kernel/power/hibernate.c:1074:28: error: passing argument 3 of 'kstrtoul' from incompatible pointer type [-Werror=incompatible-pointer-types] int rc = kstrtoul(buf, 0, &swsusp_resume_block); ^ In file included from include/linux/list.h:9:0, from include/linux/preempt.h:11, from include/linux/spinlock.h:51, from include/linux/swap.h:5, from include/linux/suspend.h:5, from kernel/power/hibernate.c:16: include/linux/kernel.h:332:32: note: expected 'long unsigned int *' but argument is of type 'sector_t * {aka long long unsigned int *}' static inline int __must_check kstrtoul(const char *s, unsigned int base, unsigned long *res) ^~~~~~~~ cc1: some warnings being treated as errors vim +/kstrtoul +1074 kernel/power/hibernate.c 1063 1064 static ssize_t resume_offset_show(struct kobject *kobj, 1065 struct kobj_attribute *attr, char *buf) 1066 { > 1067 return sprintf(buf, "%lu\n", swsusp_resume_block); 1068 } 1069 1070 static ssize_t resume_offset_store(struct kobject *kobj, 1071 struct kobj_attribute *attr, const char *buf, 1072 size_t n) 1073 { > 1074 int rc = kstrtoul(buf, 0, &swsusp_resume_block); 1075 1076 if (rc) 1077 return rc; 1078 1079 return n; 1080 } 1081 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Attachment:
.config.gz
Description: application/gzip
